Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container events #341

Merged
merged 10 commits into from
May 15, 2023
Merged

Container events #341

merged 10 commits into from
May 15, 2023

Conversation

Tides
Copy link
Member

@Tides Tides commented Apr 29, 2023

This PR is for making close container logic to be handled by server and not by the packet itself

@Tides Tides marked this pull request as ready for review April 29, 2023 07:34
@github-actions github-actions bot added the api Relates to Obsidian.API label Apr 29, 2023
@Tides Tides added server Relates to the server implementation priority: low Nice to have networking Relates to packet changes and net-code labels Apr 29, 2023
Jonpro03
Jonpro03 previously approved these changes Apr 30, 2023
@Craftplacer
Copy link
Collaborator

@Jonpro03 can you approve again?

@Tides Tides merged commit f34009d into master May 15, 2023
2 checks passed
@Tides Tides deleted the container-events branch May 15, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Relates to Obsidian.API networking Relates to packet changes and net-code priority: low Nice to have server Relates to the server implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants